Skip to content

Make build_id param as required when updating CI minutes async

Fabio Pitino requested to merge ci-worker-make-build-id-required-param into master

What does this MR do and why?

Related to #331785 (closed)

This is the 3rd out of 4 MRs related to making the update of CI minutes consumption idempotent.

In the previous MR !69994 (merged) we passed build_id when invoking the worker that updates CI minutes consumption. Having the build_id it means we can understand whether we have already added the CI minutes job consumption to the monthly consumption.

Now that build_id is always passed in for every worker we can make it a required parameter.

This change has been performed over several MRs due to https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#multi-step-deployment.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports