Skip to content
Snippets Groups Projects

External issues list: Don't show empty state when error occurs

All threads resolved!

What does this MR do and why?

Related to #338396 (closed) (as per MR title!).

Because this MR introduces GlAlert, we'll be able to put links to docs in error messages: #337996 (closed)

Screenshots or screen recordings

jira-issues-list-error

How to set up and validate locally

  1. Select a GitLab project on your local GitLab instance.
  2. Enable and configure the Jira integration for the project. More information.
    • GitLab team members: use the Jira credentials in the shared Engineering 1Password folder.
    • Community contributors: set up your own Jira instance.
  3. Select Jira Issues in the sidebar with browser dev tools open
  4. In network tab of devtools, block the request to /-/integrations/jira/issues.json?with_labels_details=true&per_page=20&page=1&state=opened&sort=created_desc.
  5. Refresh and observe page. The Alert should be visible, and the issues list should not.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tom Quirk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Coung Ngo approved this merge request

    approved this merge request

  • Coung Ngo removed review request for @cngo

    removed review request for @cngo

  • :wave: @cngo, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Tom Quirk added 1 commit

    added 1 commit

    • f199a57c - Use GlAlert for external issues list errors

    Compare with previous version

  • Tom Quirk added 179 commits

    added 179 commits

    Compare with previous version

  • Tom Quirk requested review from @nmezzopera

    requested review from @nmezzopera

  • Nicolò Maria Mezzopera approved this merge request

    approved this merge request

  • Nicolò Maria Mezzopera resolved all threads

    resolved all threads

  • Nicolò Maria Mezzopera enabled an automatic merge when the pipeline for 9f241915 succeeds

    enabled an automatic merge when the pipeline for 9f241915 succeeds

  • Headsup: rebasing and MWPS again

  • Nicolò Maria Mezzopera aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 81 commits

    Compare with previous version

  • Nicolò Maria Mezzopera enabled an automatic merge when the pipeline for a67c0569 succeeds

    enabled an automatic merge when the pipeline for a67c0569 succeeds

  • mentioned in commit fec45f18

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #337928 (closed)

  • Tom Quirk changed the description

    changed the description

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading