External issues list: Don't show empty state when error occurs
What does this MR do and why?
Related to #338396 (closed) (as per MR title!).
Because this MR introduces GlAlert, we'll be able to put links to docs in error messages: #337996 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Select a GitLab project on your local GitLab instance.
- Enable and configure the Jira integration for the project. More information.
- GitLab team members: use the Jira credentials in the shared Engineering 1Password folder.
- Community contributors: set up your own Jira instance.
- Select Jira Issues in the sidebar with browser dev tools open
- In
network
tab of devtools, block the request to/-/integrations/jira/issues.json?with_labels_details=true&per_page=20&page=1&state=opened&sort=created_desc
. - Refresh and observe page. The Alert should be visible, and the issues list should not.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
added Deliverable UX auto updated frontend groupintegrations [DEPRECATED] priority4 sectiondev severity4 typebug workflowin dev + 1 deleted label
assigned to @tomquirk
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova ( @dzubova
) (UTC+2, 7.5 hours behind@tomquirk
)Nicolò Maria Mezzopera ( @nmezzopera
) (UTC+2, 7.5 hours behind@tomquirk
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cd1ea9b5 and 824b40be
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.23 MB 3.23 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Note: We do not have exact data for cd1ea9b5. So we have used data from: 0710efc8.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 148 commits
-
4ebe36e5...72485b12 - 147 commits from branch
master
- 667158f0 - Use GlAlert for external issues list errors
-
4ebe36e5...72485b12 - 147 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Nicolò Maria Mezzopera
Hey @cngo, could you please review this MR?
added workflowin review label and removed workflowin dev label
requested review from @cngo
Allure report
allure-report-publisher
generated test report for 824b40be!review-qa-smoke:
test report- Resolved by Tom Quirk
removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 179 commits
-
f199a57c...cbc1b00b - 178 commits from branch
master
- ce0df3bb - Use GlAlert for external issues list errors
-
f199a57c...cbc1b00b - 178 commits from branch
requested review from @nmezzopera
enabled an automatic merge when the pipeline for 9f241915 succeeds
added 81 commits
-
ce0df3bb...cd1ea9b5 - 80 commits from branch
master
- 824b40be - Use GlAlert for external issues list errors
-
ce0df3bb...cd1ea9b5 - 80 commits from branch
enabled an automatic merge when the pipeline for a67c0569 succeeds
mentioned in commit fec45f18
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #337928 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
added releasedpublished label and removed releasedcandidate label
added devopsmanage label and removed 1 deleted label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label