Skip to content

Rename Ci::StuckBuilds::DropService to DropPendingService

drew stachon requested to merge rename-drop-service into master

What does this MR do and why?

This MR renames the Ci::StuckBuildsDropService to DropPendingService to reflect it's behavior of only querying pending builds to be dropped. It used to handle all states of builds in sequence, but the work for running !70233 (merged) and scheduled !71229 (merged) builds has been moved out of this Service and into separate ones.

Renaming this service is just helpful for other contributors to more easily discern what happens in this service, as opposed to the other two.

I've decided against changing the StuckCiJobsWorker name for now, since we're going to evaluate the performance of the three jobs separately and make a final decision about cronjobs and scheduling. The responsibility of this worker will be ultimately decided then, and the service likely to be renamed at that time anyway, so I'm not going to bother with the churn in the meantime.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by drew stachon

Merge request reports