Skip to content

Do not include ActionView::Helpers::UrlHelper

Eugie Limpin requested to merge eugie/remove-include-url-helper into master

What does this MR do and why?

This MR addresses #341403 (closed).

It removes the inclusion of ActionView::Helpers::UrlHelpers in lib/gitlab/email/message/in_product_marketing/helper.rb to avoid adding other methods from ActionView::Helpers::UrlHelpers when we only want to use link_to. Instead of including the whole module, link_to is directly called from ActionController::Base.helpers as suggested in #340567 (comment 674155273).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eugie Limpin

Merge request reports