Skip to content

Fix Web IDE renaming empty content

David O'Regan requested to merge 296912-rename-webide-bug into master

What does this MR do and why?

A small(temporary) fix for: #296912 (closed). In this fix, we remove a current ternary from createCommitPayload which would often null the content of a staged file from our new commit.

THIS IS NOT A HOLISTIC FIX.

The holistic fix would be to discover why sometimes the files changed are not toggled with the chnaged: true Boolean inside the rootState.stagedFiles array.

Screenshots or screen recordings

R1

How to set up and validate locally

  1. Log in to GitLab as an admin: root / 5iveL!fe
  2. Navigate to any seeded project i.e. http://127.0.0.1:3000/flightjs/Flight
  3. Click Web IDE to open the Web IDE.
  4. Rename, edit and update a large selection of files.
  5. Click commit
  6. Open the Changes tab to see the correct changes reflected(Renamed, moved, staged, edited, deleted etc).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #296912 (closed)

Edited by David O'Regan

Merge request reports