Skip to content
Snippets Groups Projects

Drop Delayed Project Removal column from Namespaces

Merged Drew Blessing requested to merge dblessing_remove_delayed_project_removal_ignore into master
All threads resolved!

What does this MR do and why?

Fixes #322611 (closed)

In !53916 (merged), delayed_project_removal was migrated to namespace_settings table and in #322610 (closed) the column was ignored.

The next step is to drop the column. This is step 2 in Dropping Columns documentation.

Database

Migrate

== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: migrating ========
-- transaction_open?()
   -> 0.0000s
-- remove_column(:namespaces, :delayed_project_removal)
   -> 0.0074s
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: migrated (0.0519s)

Rollback

== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: reverting ========
-- transaction_open?()
   -> 0.0000s
-- add_column(:namespaces, :delayed_project_removal, :boolean, {:default=>false, :null=>false, :if_not_exists=>true})
   -> 0.0054s
-- transaction_open?()
   -> 0.0000s
-- index_exists?(:namespaces, :id, {:name=>"tmp_idx_on_namespaces_delayed_project_removal", :where=>"delayed_project_removal = TRUE", :algorithm=>:concurrently})
   -> 0.0151s
-- execute("SET statement_timeout TO 0")
   -> 0.0007s
-- add_index(:namespaces, :id, {:name=>"tmp_idx_on_namespaces_delayed_project_removal", :where=>"delayed_project_removal = TRUE", :algorithm=>:concurrently})
   -> 0.0051s
-- execute("RESET statement_timeout")
   -> 0.0006s
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: reverted (0.0598s)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Drew Blessing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Drew Blessing changed the description

    changed the description

  • Drew Blessing added 1 commit

    added 1 commit

    • fda7457f - Drop Delayed Project Removal column from Namespaces

    Compare with previous version

  • Drew Blessing added 1 commit

    added 1 commit

    • 8caa6d67 - Drop Delayed Project Removal column from Namespaces

    Compare with previous version

  • Drew Blessing added 1 commit

    added 1 commit

    • 4dd9579d - Drop Delayed Project Removal column from Namespaces

    Compare with previous version

  • Drew Blessing added 612 commits

    added 612 commits

    Compare with previous version

  • Diogo Frazão approved this merge request

    approved this merge request

  • Diogo Frazão assigned to @ahegyi and unassigned @dblessing

    assigned to @ahegyi and unassigned @dblessing

  • Diogo Frazão requested review from @ahegyi

    requested review from @ahegyi

  • Diogo Frazão removed review request for @dfrazao-gitlab

    removed review request for @dfrazao-gitlab

  • :wave: @dfrazao-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • unassigned @ahegyi

  • Adam Hegyi
  • Thanks, @dblessing! I left one comment about with_lock_retries.

  • Drew Blessing changed the description

    changed the description

  • Drew Blessing added 1 commit

    added 1 commit

    • 6262b4c5 - Drop Delayed Project Removal column from Namespaces

    Compare with previous version

  • added databaseapproved label and removed databasereviewed label

  • Adam Hegyi approved this merge request

    approved this merge request

  • Adam Hegyi resolved all threads

    resolved all threads

  • Thanks, @dblessing! DB LGTM! :thumbsup:

  • merged

  • Adam Hegyi mentioned in commit b27841cc

    mentioned in commit b27841cc

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading