Drop Delayed Project Removal column from Namespaces
What does this MR do and why?
Fixes #322611 (closed)
In !53916 (merged), delayed_project_removal
was migrated to namespace_settings
table and in #322610 (closed) the column was ignored.
The next step is to drop the column. This is step 2 in Dropping Columns documentation.
Database
Migrate
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: migrating ========
-- transaction_open?()
-> 0.0000s
-- remove_column(:namespaces, :delayed_project_removal)
-> 0.0074s
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: migrated (0.0519s)
Rollback
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: reverting ========
-- transaction_open?()
-> 0.0000s
-- add_column(:namespaces, :delayed_project_removal, :boolean, {:default=>false, :null=>false, :if_not_exists=>true})
-> 0.0054s
-- transaction_open?()
-> 0.0000s
-- index_exists?(:namespaces, :id, {:name=>"tmp_idx_on_namespaces_delayed_project_removal", :where=>"delayed_project_removal = TRUE", :algorithm=>:concurrently})
-> 0.0151s
-- execute("SET statement_timeout TO 0")
-> 0.0007s
-- add_index(:namespaces, :id, {:name=>"tmp_idx_on_namespaces_delayed_project_removal", :where=>"delayed_project_removal = TRUE", :algorithm=>:concurrently})
-> 0.0051s
-- execute("RESET statement_timeout")
-> 0.0006s
== 20210923135909 RemoveDelayedProjectRemovalFromNamespaces: reverted (0.0598s)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
assigned to @dblessing
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- A deleted user
added databasereview pending label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
db/post_migrate/20210923135909_remove_delayed_project_removal_from_namespaces.rb
db/schema_migrations/20210923135909
db/structure.sql
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer database Diogo Frazão ( @dfrazao-gitlab
) (UTC+2, 7 hours ahead of@dblessing
)Tiger Watson ( @tigerwnz
) (UTC+11, 16 hours ahead of@dblessing
)~migration No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 8c608eec - Drop Delayed Project Removal column from Namespaces
added 1 commit
- 084c80d5 - Drop Delayed Project Removal column from Namespaces
Setting label(s) ~"Category:Authentication and Authorization" sectiondev based on ~"group::access".
added sectiondev + 1 deleted label
@dblessing, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
- Resolved by Adam Hegyi
@dfrazao-gitlab Do you mind doing an initial database review, please?
requested review from @dfrazao-gitlab
- Resolved by Drew Blessing
- Resolved by Drew Blessing
mentioned in issue gitlab-com/www-gitlab-com#12063 (closed)
added 1 commit
- fda7457f - Drop Delayed Project Removal column from Namespaces
added 1 commit
- 8caa6d67 - Drop Delayed Project Removal column from Namespaces
added 1 commit
- 4dd9579d - Drop Delayed Project Removal column from Namespaces
added 612 commits
-
4dd9579d...2b719bdf - 611 commits from branch
master
- a958ae3c - Drop Delayed Project Removal column from Namespaces
-
4dd9579d...2b719bdf - 611 commits from branch
added databasereviewed label and removed databasereview pending label
assigned to @ahegyi and unassigned @dblessing
requested review from @ahegyi
removed review request for @dfrazao-gitlab
assigned to @dblessing
@dfrazao-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
unassigned @ahegyi
- Resolved by Adam Hegyi
Thanks, @dblessing! I left one comment about
with_lock_retries
.- Resolved by Justin Stark
This will impact the data warehouse. We'll need to remove this column also from the manifest.
added 1 commit
- 6262b4c5 - Drop Delayed Project Removal column from Namespaces
added databaseapproved label and removed databasereviewed label
Thanks, @dblessing! DB LGTM!
mentioned in commit b27841cc
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
removed typefeature label
added releasedpublished label and removed releasedcandidate label