Show warning for markdown structure changes
What does this MR do and why?
Issue: #338937 (closed)
- Show a warning in content editor when on editing a document, the markdown style of the original document might not match the resulting document.
- Remove the
content_editor_block_tables
feature flag.
Screenshots or screen recordings
How to set up and validate locally
-
Create a new wiki page
-
Enter the following content:
|This is a |table| |----------|-----| |with <ul><li>hi| there|
-
Edit something in the table.
-
The warning appears.
If you dismiss the warning, it never appears again unless you refresh the page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.4
assigned to @himkp
1 Warning ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Blessing ( @dblessing
) (UTC-6, 7 hours behind@himkp
)Vasilii Iakliushin ( @vyaklushin
) (UTC+1, same timezone as@himkp
)frontend Tristan Read ( @tristan.read
) (UTC+13, 12 hours ahead of@himkp
)Illya Klymov ( @xanf
) (UTC+2, 1 hour ahead of@himkp
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 Dangeradded 534 commits
-
b122a387...cf940e83 - 533 commits from branch
master
- 830969f6 - Show warning for markdown structure changes
-
b122a387...cf940e83 - 533 commits from branch
- A deleted user
added backend label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed backend label
added featureaddition typefeature labels
- Resolved by Enrique Alcántara
@ealcantara Could you please do a review for this MR?
Edited by Himanshu Kapoor
- A deleted user
added backend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 75e4516c and 9b440585
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.55 MB 3.55 MB - 0.0 % mainChunk 2.24 MB 2.24 MB - 0.0 %
Note: We do not have exact data for 75e4516c. So we have used data from: 908b60b5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Dangermentioned in issue #332629 (closed)
added 2896 commits
-
d911e7c1...0407fa98 - 2895 commits from branch
master
- 049c9b27 - Show warning for markdown structure changes
-
d911e7c1...0407fa98 - 2895 commits from branch
- Resolved by Enrique Alcántara
@tyleramos Could you please review backend?