Allow review-build-cng jobs to fail
What does this MR do and why?
Allow review-build-cng jobs to fail.
Otherwise we can run into situations where an MR pipeline is green, and because a single CNG job fails downstream it blocks the MR merge. This happened in !70874 (merged) where a single downstream job failed with a connection error when downloading file, which turned the upstream MR build red. Even retrying that single job downstream will not fix the upstream pipeline, so the entire CNG stage has to re-run.
Most MRs will have no impact on build success
in CNG, and the CNG job is only required to
prepare review apps, which is a manual step
anyway. (only in some cases it is)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.