Skip to content

Fix method name in RetryBuildService

Fabio Pitino requested to merge fix-method-name-in-retry-ci-build-service into master

What does this MR do and why?

  • Rename reprocess! method to clone! since it's about cloning a build. The reprocessing part occurs outside this method. I found this method name confusing since it's also used in RetryPipelineService with the purpose of only cloning the builds and then issue a reprocessing of the whole pipeline at the end.
  • Remove needs variable since it's not used anymore. It was added here and removed here but we didn't remove the variable.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports