Address require-string-literal-i18n-helpers offenses

What does this MR do and why?

Address vue i18n literal string violations. Closes - #339497 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

@imrishabh18

Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!

• Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
• If you haven't, please set up a DANGER_GITLAB_API_TOKEN.
• You can comment @gitlab-bot label ~"group::" to add a group label.
• After a few days, feel free to ask @gitlab-bot help or ping a Merge Request Coach.
• Read more how to get help.

This message was generated automatically. You're welcome to improve it.

added Community contribution label

This MR will be considered part of the quarterly GitLab Hackathon for a chance to win a prize.

Can you make sure this MR is mentioning/linking the relevant issue that it's attempting to close?

Thank you for your contribution!

@pgascouvaillancourt Can you tell me what should be used in-place of n__ pls at 64 line number?

@imrishabh18 Thanks for working on this! To answer your question, you can update this with the values from lines 23 and 24. Those i18n values should be safe to remove afterwards.

return n__(
  'PackageRegistry|Package has %{number} archived update',
  'PackageRegistry|Package has %{number} archived updates',
  this.archiviedLines,
);

added Hackathon label

mentioned in issue gitlab-org/quality/triage-reports#4705 (closed)

mentioned in issue gitlab-org/quality/triage-reports#4754 (closed)

Thank you for the contribution, @imrishabh18

@mgandres can you review this community contribution and help them get it merged? Thanks.

added Category:Design System frontend groupfoundations sectiondev typemaintenance labels

requested review from @mgandres

assigned to @imrishabh18

added typefeature label

Setting label(s) devopsecosystem based on groupfoundations.

added 1 deleted label

added 829 commits

• 9f72f25e...cbc1b00b - 822 commits from branch gitlab-org:master
• 6ccf767a - Rebase master and updated gitlab.pot
• f0045db8 - Address vue i18n literal string violations
• 4b142b48 - Removed event_hub.js
• 529a7bb9 - Merge remote-tracking branch 'upstream/master'
• c8cbed5d - Rebase master
• 50d0147e - Address require-string-literal-i18n-helpers offenses
• 06e9b753 - i18n for package-registry

Compare with previous version

added 1 commit

• 467aa8ab - Removed the lines, no longer being used

Compare with previous version

approved this merge request

@mgandres, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

	6 Warnings
	06e9b753: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	c8cbed5d: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	529a7bb9: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	4b142b48: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	This merge request does not refer to an existing milestone.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Himanshu Kapoor (@himkp) (UTC+2)	Savas Vedova (@svedova) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2b719bdf and fd88f02e

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.23 MB	3.23 MB	+1.01 KB	0.0 %
mainChunk	1.89 MB	1.89 MB	-	0.0 %

Significant Growth: 12

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.epics.new	1.3 MB	1.61 MB	+326.86 KB	24.6 %
pages.profiles.personal_access_tokens	226.38 KB	341.81 KB	+115.43 KB	51.0 %
pages.profiles	166.56 KB	281.81 KB	+115.25 KB	69.2 %
pages.profiles.slacks	174.35 KB	289.6 KB	+115.25 KB	66.1 %
pages.profiles.two_factor_auths	302.43 KB	416.34 KB	+113.91 KB	37.7 %
pages.profiles.preferences.show	182.61 KB	295.88 KB	+113.27 KB	62.0 %
pages.profiles.show	1021.15 KB	1.1 MB	+109.39 KB	10.7 %
pages.profiles.accounts.show	309.94 KB	350.23 KB	+40.3 KB	13.0 %
pages.profiles.billings	290.18 KB	330.48 KB	+40.3 KB	13.9 %
pages.profiles.keys	247.18 KB	287.48 KB	+40.3 KB	16.3 %

The table above is limited to 10 entries. Please look at the full report for more details

New entry points: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.profiles.password_prompt	0 Bytes	281.83 KB	+281.83 KB	100.0 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report for fd88f02e!

review-qa-smoke: test report

@imrishabh18 There are some pipeline failures.

Changes in translated strings found, please update file `/builds/gitlab-org/gitlab/locale/gitlab.pot` by running:
  bin/rake gettext:regenerate
Then commit and push the resulting changes to `/builds/gitlab-org/gitlab/locale/gitlab.pot`.

Since we updated the strings, could you run bin/rake gettext:regenerate?

Hi @imrishabh18 just checking in. There are some changes here that seems different from the updated master branch. Perhaps we need a rebase? I think there shouldn't be complaints with regenerating text stings here once we do that

added 1 commit

• fd88f02e - Updated after the review

Compare with previous version

added 1319 commits

• fd88f02e...4fe41b1e - 1310 commits from branch gitlab-org:master
• 556e4232 - Rebase master and updated gitlab.pot
• e2dcf866 - Rebase master
• 57bcd7ea - Removed event_hub.js
• 8fb07cac - Rebase master
• 7f11e59c - Address require-string-literal-i18n-helpers offenses
• ff6af1c4 - i18n for package-registry
• 07e15ec0 - Removed the lines, no longer being used
• 9ffdca0e - Updated after the review
• 10ff7558 - Updated gitlab.pot

Compare with previous version

@imrishabh18 hey thanks for sticking this one out, we're in the last stretch! It looks like you pushed some merge conflicts here in a lot of the .po files though

I think what you can do is:

• git pull on the master branch
• Checkout to you previous commit 9ffdca0e9f9f51928e994736cbf7ef31386f82bf
• git rebase master

This should put your commit on top of the latest changes in the master branch. I noticed there will be some conflicts, for example: ee/app/assets/javascripts/ci_minutes_usage/components/minutes_usage_project_chart.vue is already updated to use getTranslatedMonthName(monthName) so we can keep that in and just include the changes relevant to the MR.

• in app/assets/javascripts/packages_and_registries/infrastructure_registry/details/components/package_history.vue I believe shouldn't be any changes in combinedUpdateText since those are not relevant to the MR either

Hope this makes things clear!

changed this line in version 6 of the diff

I did reset the .po files, but not sure where is this other changes in the file got commited.

added 1 commit

• 1d1c597e - resolved the merge conflicts

Compare with previous version

@imrishabh18 did you mean to remove this? It's a recent change so I think we should keep this in. Other than that, this MR looks good!

Okay, if it's Looks good to you. Please Merge this before tomorrow so that it can be counted towards the hackathon

mentioned in merge request !72385 (merged)

Let's close this in favor of !72385 (merged).

closed

mentioned in merge request !72387 (merged)

added devopsmanage label and removed 1 deleted label