Skip to content

Graceful degradation for Branches controller

Vasilii Iakliushin requested to merge 340817_graceful_degradation into master

What does this MR do and why?

Contributes to #340817 (closed)

Problem

We return a 500 error page when Gitaly is not available. It is not a great user experience.

Solution

Handle Gitaly exception and successfully render the page with an error message block.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Go to project page
  2. Click on Branches link (should be something like https://gitlab.com/gitlab-org/gitlab/-/branches)
  3. Stop gitaly process
gdk stop gitaly
  1. Refresh the page
  2. Verify that page successfully loads and shows an error message

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mike Nichols

Merge request reports