Skip to content

Update deprecated GlIcon size in IDE preview navigator

James Chen-Smith requested to merge (removed):324781-update-glicon-size-ide-preview-navigator into master

Summary

Updates gl-icon to use default size (16 px), and removes the use-deprecated-sizes attribute. The valid sizes to choose from are in variables.scss.

Screenshots

Before (18px) After (16px)
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Set up project in Gitpod.
  2. Open local instance in browser.
  3. Log in as admin user.
  4. Enable Web IDE in admin settings.
  5. Open sample project in Web IDE.
  6. Select Live preview in right navigation.
  7. Inspect refresh icon.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports