Address vue i18n literal string violations
What does this MR do and why?
Address vue i18n literal string violations
Closes - #339501 (closed)
Screenshots or screen recordings
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN. - You can comment
@gitlab-bot label ~"group::"to add a group label. - After a few days, feel free to ask
@gitlab-bot helpor ping a Merge Request Coach. - Read more how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
added Hackathon label
mentioned in issue gitlab-org/quality/triage-reports#4703 (closed)
- Resolved by Paul Gascou-Vaillancourt
@imrishabh18 Thanks for the contribution!
Could you fix the pipeline failures (they look like static linting issues, so nothing major!) and ping me. Once that's done, I can pass it to a frontend maintainer for merging.
Thanks!
- Last reply by Rishabh Gupta
added frontend label
mentioned in issue gitlab-org/quality/triage-reports#4705 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4754 (closed)
added Category:Internationalization devopsmanage sectiondev typefeature typemaintenance + 1 deleted label
added 829 commits
-
734a5778...cbc1b00b - 822 commits from branch
gitlab-org:master - 6ccf767a - Rebase master and updated gitlab.pot
- f0045db8 - Address vue i18n literal string violations
- 4b142b48 - Removed event_hub.js
- 529a7bb9 - Merge remote-tracking branch 'upstream/master'
- 81ec14ed - Rebase master
- 9222b234 - Address vue i18n literal string helpers
- fe9403ec - Address vue i18n literal string helpers
Toggle commit list-
734a5778...cbc1b00b - 822 commits from branch
changed milestone to %14.4
requested review from @pgascouvaillancourt
assigned to @imrishabh18
Thank you for your help with this @imrishabh18
Ah, it looks like I'm not allowed to push to your fork @imrishabh18. Would you mind applying my suggestions please?
Thanks for making those changes @imrishabh18!
So it looks like we only need to update the translations file to wrap this up now. I ran the update locally and here's the diff:
diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 61406b0c5c7..1ab564b2fe4 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -194,9 +194,6 @@ msgid_plural "%d commits," msgstr[0] "" msgstr[1] "" -msgid "%d commits" -msgstr "" - msgid "%d completed issue" msgid_plural "%d completed issues" msgstr[0] ""To apply this patch:
- Copy the whole code block above.
- In the
gitlab/directory, runpbpaste | git apply. - Stage, commit and push the changes.
Then we should be good to go! Let me know if you need further assistance with applying these changes,
Edited by Paul Gascou-Vaillancourt
5 Warnings 
81ec14ed: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 529a7bb9: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 4b142b48: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelogtrailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: truetrailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslintrules. Please consider fixing them:app/assets/javascripts/vue_merge_request_widget/components/states/commits_header.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_merge_request_widget/components/states/commits_header.vue'Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova ( @dzubova) (UTC+2)Kushal Pandya ( @kushalpandya) (UTC+5.5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2b719bdf and 48c59f4d
Entrypoint / Name Size before Size after Diff Diff in percent average 3.23 MB 3.23 MB +1.01 KB 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.epics.new 1.3 MB 1.61 MB +326.86 KB 24.6 % pages.profiles.personal_access_tokens 226.38 KB 341.81 KB +115.43 KB 51.0 % pages.profiles 166.56 KB 281.81 KB +115.25 KB 69.2 % pages.profiles.slacks 174.35 KB 289.6 KB +115.25 KB 66.1 % pages.profiles.two_factor_auths 302.43 KB 416.34 KB +113.91 KB 37.7 % pages.profiles.preferences.show 182.61 KB 295.88 KB +113.27 KB 62.0 % pages.profiles.show 1021.15 KB 1.1 MB +109.39 KB 10.7 % pages.profiles.accounts.show 309.94 KB 350.23 KB +40.3 KB 13.0 % pages.profiles.billings 290.18 KB 330.48 KB +40.3 KB 13.9 % pages.profiles.keys 247.18 KB 287.48 KB +40.3 KB 16.3 % The table above is limited to 10 entries. Please look at the full report for more details
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.profiles.password_prompt 0 Bytes 281.83 KB +281.83 KB 100.0 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov,@justin_ho,@mikegreilingor@nmezzopera) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report for 48c59f4d!review-qa-smoke:
mentioned in merge request !72387 (merged)
Closing in favor of !72387 (merged).
mentioned in merge request gitlab-com/www-gitlab-com!122231 (merged)
added groupimport and integrate label and removed 1 deleted label
added linked-issue label
