Set assumeImmutableResults to true for token access

What does this MR do and why?

The aim of this MR is to enable assumeImmutableResults to enforce immutability.
Closes - #338445 (closed)

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

@imrishabh18

Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!

• Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
• If you haven't, please set up a DANGER_GITLAB_API_TOKEN.
• You can comment @gitlab-bot label ~"group::" to add a group label.
• After a few days, feel free to ask @gitlab-bot help or ping a Merge Request Coach.
• Read more how to get help.

This message was generated automatically. You're welcome to improve it.

added Community contribution label

This MR will be considered part of the quarterly GitLab Hackathon for a chance to win a prize.

Can you make sure this MR is mentioning/linking the relevant issue that it's attempting to close?

Thank you for your contribution!

added Hackathon label

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

added 1 commit

• 38425a6f - removing event_hub.js file

Compare with previous version

changed title from Imrishabh18 338445 to Set assumeImmutableResults to true for token access

mentioned in issue gitlab-org/quality/triage-reports#4703 (closed)

added frontend maintenancerefactor labels

mentioned in issue gitlab-org/quality/triage-reports#4705 (closed)

mentioned in issue gitlab-org/quality/triage-reports#4754 (closed)

Thank you for the contribution, @imrishabh18

@thomasrandolph can you review this community contribution and help them get it merged? Thanks.

added Category:Design System groupfoundations sectiondev typemaintenance labels

requested review from @thomasrandolph

assigned to @imrishabh18

added typefeature label

	3 Warnings
	937895cc: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	399a1680: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Sheldon Led (@sheldonled) (UTC+1)	Miguel Rincon (@mrincon) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@imrishabh18 I'm not sure why this is erroring so badly, but could you try to rebase against the master gitlab branch and see if that corrects this config issue?

You may need to drop all of your commits except for the feature change for the rebase to apply cleanly, but that shouldn't be an issue as you'll get all the merged changes after the rebase.

I'll retry the Dangerbot job to see if this fails every time

Seems like it does, we'll see after the rebase.

@thomasrandolph I have rebased the branch with the master successfully and tried to force pushed the branch. Can you help me resolve this error please while pushing the branch? I haven't changed any Changelog file or something.

@imrishabh18

Great work!

The changes reported there are almost certainly in this commit, which has this changelog:

That's a lot!

The easiest way to resolve this is:

1. Copy your change (defaultClient: createDefaultClient({}, { assumeImmutableResults: true }),) somewhere safe (like a text file)
2. Reset your branch to the gitlab-org/gitlab master branch. It may be most convenient to check out the current tip of master locally, and then reset to that local copy.
   • If you check out master locally, then switch back to your branch, you can run this command (bash): git reset `git rev-parse master` --hard
   • When you do this, you'll note that everything in your branch is gone! Aah! Don't worry, we'll re-add your work in the next step!
3. Re-add your change from step 1
4. Re-commit
5. Force push

@thomasrandolph I have rebased the branch. But still this pipeline fails, Can you look into this please, what should I do next?

@imrishabh18 Thanks for doing that!

I think the pipeline may have been failing because it was running from a fork (or it was just a fluke!).

It seems fine now after I re-ran it, so I'm approving this and passing it along!

@peterhegman Would you be able to take over as maintainer for this change?

@imrishabh18 thanks for the contribution! @thomasrandolph thanks for reviewing and helping get the pipeline passing. This change makes sense to me. I clicked around locally and inspected the related code without noticing any issues so we should be good to go

Going to start a new pipeline and merge when that passes.

Thanks! @thomasrandolph and @peterhegman

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits bc5d7fae and 937895cc

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.23 MB	3.23 MB	-1.01 KB	-0.0 %
mainChunk	1.89 MB	1.89 MB	-	-0.0 %

Significant Reduction: 11

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.epics.new	1.61 MB	1.3 MB	-326.86 KB	-19.8 %
pages.profiles.personal_access_tokens	341.81 KB	226.38 KB	-115.43 KB	-33.8 %
pages.profiles	281.81 KB	166.56 KB	-115.25 KB	-40.9 %
pages.profiles.slacks	289.6 KB	174.35 KB	-115.25 KB	-39.8 %
pages.profiles.two_factor_auths	416.34 KB	302.43 KB	-113.91 KB	-27.4 %
pages.profiles.preferences.show	295.88 KB	182.61 KB	-113.27 KB	-38.3 %
pages.profiles.show	1.1 MB	1021.15 KB	-109.39 KB	-9.7 %
pages.profiles.accounts.show	350.23 KB	309.94 KB	-40.3 KB	-11.5 %
pages.profiles.billings	330.48 KB	290.18 KB	-40.3 KB	-12.2 %
pages.profiles.keys	287.48 KB	247.18 KB	-40.3 KB	-14.0 %

The table above is limited to 10 entries. Please look at the full report for more details

---

Note: We do not have exact data for bc5d7fae. So we have used data from: 70f49a7d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report for 937895cc!

review-qa-smoke: test report

Setting label(s) devopsecosystem based on groupfoundations.

added 1 deleted label

mentioned in merge request !70980 (closed)

added 622 commits

• 38425a6f...2b719bdf - 619 commits from branch gitlab-org:master
• 399a1680 - Update event_hub.js
• b8be51e0 - Setting assumeImmutableResults to true
• 937895cc - removing event_hub.js file

Compare with previous version

approved this merge request

requested review from @peterhegman and removed review request for @thomasrandolph

@thomasrandolph, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

changed milestone to %14.4

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 6c9cdce5 succeeds

merged

mentioned in commit de8519cc

added workflowverification label

added workflowstaging-canary label and removed workflowverification label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

added releasedcandidate label

removed typefeature label

added releasedpublished label and removed releasedcandidate label

added devopsmanage label and removed 1 deleted label