Use UserNamespacePolicy for user namespaces
What does this MR do and why?
We're converting to using Namespaces::UserNamespace
.
This MR converts NamespacePolicy
into Namespaces::UserNamespacePolicy
FYI, GroupPolicy
does not inherit from NamespacePolicy
, as one might expect. They both inherited from BasePolicy
. This means we can make Namespaces::UserNamespacePolicy
inherit from BasePolicy
, and have NamespacePolicy
inherit from Namespaces::UserNamespacePolicy
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #341124 (closed)
Merge request reports
Activity
assigned to @digitalmoksha
added 1 commit
- 6338f5e1 - Shift NamespacePolicy to UserNamespacePolicy
- A deleted user
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Diogo Frazão ( @dfrazao-gitlab
) (UTC+2, 7 hours ahead of@digitalmoksha
)Stan Hu ( @stanhu
) (UTC-7, 2 hours behind@digitalmoksha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- a8420489 - Shift NamespacePolicy to UserNamespacePolicy
changed milestone to %14.4
added workflowin dev label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Brett Walker
@jprovaznik would you mind doing the first review of this, since you did the
ProjectNamespacePolicy
MR?
requested review from @jprovaznik
@digitalmoksha, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
- Resolved by Terri Chu
removed review request for @jprovaznik
@jprovaznik
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added workflowin review label and removed workflowin dev label
@ifarkas Could you do the maintainer review?
requested review from @ifarkas
enabled an automatic merge when the pipeline for 3a313376 succeeds
mentioned in commit 16254e21
mentioned in issue #341124 (closed)
added workflowstaging-canary label and removed workflowin review label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
removed typefeature label
added releasedpublished label and removed releasedcandidate label