Skip to content
Snippets Groups Projects

Use UserNamespacePolicy for user namespaces

Merged Brett Walker requested to merge 341124-use-usernamespacepolicy-for-user-namespaces into master
All threads resolved!

What does this MR do and why?

We're converting to using Namespaces::UserNamespace.

This MR converts NamespacePolicy into Namespaces::UserNamespacePolicy

FYI, GroupPolicy does not inherit from NamespacePolicy, as one might expect. They both inherited from BasePolicy. This means we can make Namespaces::UserNamespacePolicy inherit from BasePolicy, and have NamespacePolicy inherit from Namespaces::UserNamespacePolicy.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341124 (closed)

Edited by Brett Walker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Provaznik approved this merge request

    approved this merge request

  • Jan Provaznik removed review request for @jprovaznik

    removed review request for @jprovaznik

  • :wave: @jprovaznik, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • added workflowin review label and removed workflowin dev label

  • @ifarkas Could you do the maintainer review?

  • Brett Walker requested review from @ifarkas

    requested review from @ifarkas

  • Brett Walker requested review from @terrichu and removed review request for @ifarkas

    requested review from @terrichu and removed review request for @ifarkas

  • Terri Chu approved this merge request

    approved this merge request

  • Terri Chu resolved all threads

    resolved all threads

  • Terri Chu enabled an automatic merge when the pipeline for 3a313376 succeeds

    enabled an automatic merge when the pipeline for 3a313376 succeeds

  • merged

  • Terri Chu mentioned in commit 16254e21

    mentioned in commit 16254e21

  • mentioned in issue #341124 (closed)

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading