Skip to content

Address followup items

Nikola Milojevic requested to merge 341022-follow-up-idempotent-lb-workers into master

What does this MR do and why?

This MR does refactor deduplication strategies and DeduplicatesWhenScheduling making overrides more logical and readable, by extracting DeduplicatesWhenScheduling as an abstract class. It also fixes readability for DuplicateJob. In order to prevent bugs and issues, we made Gitlab::Databaase::DATABASES to be hash with indifferent access so it can accept both strings and symbols.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341022 (closed)

Merge request reports