Resolve "Time tooltips incorrectly display time zones"
What does this MR do and why?
This MR temporarily moves the node-dateformat
library into vendor/assets/javascripts/dateformat.js
so that we can fix a bug in timezone formatting which is still pending an upstream release. (#225290 (closed))
This MR updates node-dateformat
to the latest version, which incorporates an upstream fix for timezone abbreviations that were primarily screwing up Australian timezones (see #225290 (closed))
Link to upstream MR: https://github.com/felixge/node-dateformat/pull/166
Screenshots or screen recordings
Before (with timezone set to AEST) | After (with timezone set to AEST) |
---|---|
How to set up and validate locally
-
Change your timezone to an Australian 4-letter abbreviated timezone. On MacOS you must do this in your system settings under "Date & Time -> Timezone". Click the padlock, enter your password, uncheck "Set timezone automatically" and click somewhere on Australia's east coast:
-
Run your GDK and visit any page with mouse-over tooltips.
-
Note that without the changes in this MR, you see an incorrect timezone abbreviation (
AEST
appears asEST
). -
Check out the changes in this MR and observe that the timezone abbreviation renders correctly (
AEST
appears correctly)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #225290 (closed)