Skip to content

Resolve "Time tooltips incorrectly display time zones"

Mike Greiling requested to merge 225290-time-tooltips-incorrectly-display-time-zones into master

What does this MR do and why?

This MR temporarily moves the node-dateformat library into vendor/assets/javascripts/dateformat.js so that we can fix a bug in timezone formatting which is still pending an upstream release. (#225290 (closed))

This MR updates node-dateformat to the latest version, which incorporates an upstream fix for timezone abbreviations that were primarily screwing up Australian timezones (see #225290 (closed))

Link to upstream MR: https://github.com/felixge/node-dateformat/pull/166

Screenshots or screen recordings

Before (with timezone set to AEST) After (with timezone set to AEST)
before after

How to set up and validate locally

  1. Change your timezone to an Australian 4-letter abbreviated timezone. On MacOS you must do this in your system settings under "Date & Time -> Timezone". Click the padlock, enter your password, uncheck "Set timezone automatically" and click somewhere on Australia's east coast: changing_timezone

  2. Run your GDK and visit any page with mouse-over tooltips.

  3. Note that without the changes in this MR, you see an incorrect timezone abbreviation (AEST appears as EST).

  4. Check out the changes in this MR and observe that the timezone abbreviation renders correctly (AEST appears correctly)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #225290 (closed)

Edited by Mike Greiling

Merge request reports