Skip to content

Add pending SaaS users to "Invited" members tab [RUN AS-IF-FOSS]

Sheldon Led requested to merge led/334288-add-pending-users-invited-tab into master

What does this MR do and why?

Relates to: #334288 (closed)

With the User Cap setting, admins can prevent accidental user overages, so when the group is at limit of number of users, they should be on the invited tab, with Pending Owner Approval status (a badge will be added here: !70682 (merged))

Screenshots or screen recordings

Group Members

Before After
pending_group_members_invited_tab_before pending_group_members_invited_tab_after

Project Members

Before After
pending_project_members_invited_tab_before pending_project_members_invited_tab_after

How to set up and validate locally

Enable User Cap

  1. Activate Feature Flag using rails c
    1. my_group = Group.find(<group_id>)
    2. Feature.enable(:saas_user_caps, my_group)
  2. On the same rails console session, check user cap
    1. my_group.user_cap_reached?. Output should be false
    2. my_group.namespace_settings.update!(new_user_signups_cap: my_group.group_members.count)
    3. my_group.user_cap_reached?. Output should be true

Add members

  1. Go to the browser, and navigate to groups/my_group/-/group_members
  2. Add a new member (e.g. @valeria from the seeded data)

Behavior

  • Before: The new user would appear in the "Members" tab
  • With this MR: The new user appears in the invited tab

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Etienne Baqué

Merge request reports