Skip to content

Footnotes with "w" in the anchor don't render as footnotes!

What does this MR do and why?

This bug in cmark-gfm is now fixed, allowing footnote references to have a w in there name.

Updated commonmarker gem to 0.23.2

Screenshots or screen recordings

Taken from the issue, this markdown should now render correctly

Footnotes are only recognised sometimes.[^like-this]

The problem seems to be when there's a w in the footnote anchor.[^w]

Anchors without w seem to render OK. It's just those with w that get ignored.[^a] [^w2] [^a2] [^this-is-not-awesome] [^this-is-not-rad]

[^like-this]: Like this.
  
[^w]: This won't be rendered.
  
[^a]: This will be rendered.
  
[^w2]: This won't be rendered.
  
[^a2]: This will be rendered.
  
[^this-is-not-awesome]: This will not be rendered.
  
[^this-is-not-rad]: This will be rendered.

Footnotes are only recognised sometimes.1

The problem seems to be when there's a w in the footnote anchor.2

Anchors without w seem to render OK. It's just those with w that get ignored.3 4 5 6 7


How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #24423 (closed)

  1. Like this.

  2. This won't be rendered (but now if - Fixed!!).

  3. This will be rendered.

  4. This won't be rendered (but now if - Fixed!!).

  5. This will be rendered.

  6. This will not be rendered (but now if - Fixed!!).

  7. This will be rendered.

Edited by Brett Walker

Merge request reports