Fix Web IDE terminal button on relative URL root
What does this MR do and why?
This MR fixes #13833 (closed) where a URL being built on the FE neglected to check for gon.relative_url_root
.
Screenshots or screen recordings
Description | Before | After |
---|---|---|
With relative_url_root: /gitlabbin
|
![]() |
![]() |
Without relative_url_root (should be no changes) |
![]() |
![]() |
How to set up and validate locally
- Add
relative_url_root: /gitlabbin
to yourgdk.yml
- Run
gdk reconfigure
- Start gdk with
gdk start
- Visit your gdk in the browser with the relative url root (example,
https://gitlab.test:3443/gitlabbin
) - Visit a project and click "Web IDE"
- You should see the "Web Terminal" icon in the right sidebar and the request to
ide_terminals/check_config
will either be 200 or 422 (this is an expected error code).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
References
Related to #13833 (closed)
Edited by Paul Slaughter