Skip to content

Exclude non migration classes from Migration/VersionedMigration cop

Fabio Pitino requested to merge fix-ar-classes-in-versioned--migration-cop into master

What does this MR do?

In !69502 (diffs, comment 670495590) we noticed a false positive in the use of Migration/VersionedMigration cop.

We were flagging as offences classes that were defined inside a migration class like:

class SetDefaultJobTokenScopeFalse < Gitlab::Database::Migration[1.0]
  class ProjectCiCdSetting < ApplicationRecord
  end
end

Instead we should flag the offence if the class is an AR migration specifically.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports