Skip to content

Cleanup bigint conversion for geo_job_artifact_deleted_events

What does this MR do?

This MR removes columns and triggers used for the bigint conversion of table geo_job_artifact_deleted_events.

  • remove column job_artifact_id_convert_to_bigint
  • remove trigger_f1ca8ec18d78 trigger and function

Related to #338050 (closed).

Database migration

Up

$ bundle exec rails db:migrate:up VERSION=20210907041000
== 20210907041000 CleanupBigintConversionForGeoJobArtifactDeletedEvents: migrating 
-- remove_column(:geo_job_artifact_deleted_events, "job_artifact_id_convert_to_bigint")
   -> 0.0011s
== 20210907041000 CleanupBigintConversionForGeoJobArtifactDeletedEvents: migrated (0.0191s) 

Down

$ bundle exec rails db:migrate:down VERSION=20210907041000
== 20210907041000 CleanupBigintConversionForGeoJobArtifactDeletedEvents: reverting 
-- table_exists?(:geo_job_artifact_deleted_events)
   -> 0.0005s
-- column_exists?(:geo_job_artifact_deleted_events, :id)
   -> 0.0009s
-- column_exists?(:geo_job_artifact_deleted_events, :job_artifact_id)
   -> 0.0008s
-- columns(:geo_job_artifact_deleted_events)
   -> 0.0009s
-- add_column(:geo_job_artifact_deleted_events, "job_artifact_id_convert_to_bigint", :int, {:default=>0, :null=>false})
   -> 0.0032s
== 20210907041000 CleanupBigintConversionForGeoJobArtifactDeletedEvents: reverted (0.0305s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338050 (closed)

Merge request reports