Skip to content

Draft: customizable HTML Title

What does this MR do?

Customization of last element of HTML Title (currently hardcoded to "GitLab") using Admin Area -> Settings -> General.

NOTE: It is early prototype - please see Questions section at the end of this MR.

There is already older issue for this request:

Screenshots or Screencasts (strongly suggested)

gitlab-edit-title

How to setup and validate locally (strongly suggested)

  1. Login to your GitLab
  2. Notice last element of HTML Title
  3. Go to Admin Area -> Settings -> General
  4. Expand "HTML Header"
  5. Verify that text-field "Site Name" value matches last element from HTML Title
  6. Change value of text-field "Site Name"
  7. click on "Save changes
  8. Verify that last element of HTML Title changes to value entered in text-field.

Does this MR meet the acceptance criteria?

Not yet. It is PoC.

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Migration Up/Down

Here is database migration dump:

$ gdk stop
$ gdk start postgresql
$ cd gitlab
$ rails db:migrate:up VERSION=20210906085213

== 20210906085213 AddSiteNameApplicationSetting: migrating ====================
-- add_column(:application_settings, :site_name, :string, {:default=>"GitLab", :null=>false})
   -> 0.0051s
== 20210906085213 AddSiteNameApplicationSetting: migrated (0.0052s) ===========

$ rails db:migrate:down VERSION=20210906085213
== 20210906085213 AddSiteNameApplicationSetting: reverting ====================
-- remove_column(:application_settings, :site_name, :string, {:default=>"GitLab", :null=>false})
   -> 0.0047s
== 20210906085213 AddSiteNameApplicationSetting: reverted (0.0570s) ===========

Questions

  1. I added this field site_name to model application_setting. Should I rather use appearance for such purpose?
  2. Should I add this field site_name as mandatory to API (thus breaking existing clients)?
Edited by Henryk Paluch

Merge request reports