Skip to content

Resolve "Address the Primary Key Overflow risk for the taggings table - Step 3: remove temporary columns and trigger"

What does this MR do?

This MR removes the columns id_convert_to_bigint, taggable_id_convert_to_bigint and the trigger trigger_aebe8b822ad3 from the taggings table.

migration up:

== 20210906130643 DropTemporaryColumnsAndTriggersForTaggins: migrating ========
-- remove_column("taggings", "id_convert_to_bigint")
   -> 0.0014s
-- remove_column("taggings", "taggable_id_convert_to_bigint")
   -> 0.0005s
== 20210906130643 DropTemporaryColumnsAndTriggersForTaggins: migrated (0.0229s)

migration down:

== 20210906130643 DropTemporaryColumnsAndTriggersForTaggins: reverting ========
-- table_exists?("taggings")
   -> 0.0006s
-- column_exists?("taggings", :id)
   -> 0.0013s
-- column_exists?("taggings", "id")
   -> 0.0009s
-- column_exists?("taggings", "taggable_id")
   -> 0.0009s
-- columns("taggings")
   -> 0.0010s
-- add_column("taggings", "id_convert_to_bigint", :int, {:default=>0, :null=>false})
   -> 0.0021s
-- columns("taggings")
   -> 0.0009s
-- add_column("taggings", "taggable_id_convert_to_bigint", :int, {:default=>nil})
   -> 0.0009s
== 20210906130643 DropTemporaryColumnsAndTriggersForTaggins: reverted (0.0376s)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338055 (closed)

Edited by Diogo Frazão

Merge request reports