Skip to content

Add Ci::StuckBuilds::DropService for use in StuckCiJobsWorker

drew stachon requested to merge refactor-stuck-service into master

What does this MR do?

This MR moves logic out of the StuckCiBuildsWorker and into a DropService that can be utilized by many separate workers. This is the first step in an effort #334399 (closed) to eventually move the queries for stuck builds out into separate workers, by build status, to improve reliability in the event that one query times out or fails.

The plans are largely laid out in !64635 (closed).

How to setup and validate locally (strongly suggested)

There is no outward-facing behavioral change in this merge request. To validate that it works, see the specs that have been moved directly into the DropService spec file from the StuckCiJobsWorker spec file, without substantial changes.

To be sure of this, the logic was moved in the first commit without any spec modification, beyond a some reference changes due to methods and constants that are no longer defined in the same place. All of the specs remain in place there, all passing.

In the second commit, we move the specs over without changing any application logic. Here, the behaviors similarly remain the same with no failures.

The third commit merely adds some assertions about DropService#execute implementation details to shore up our confidence as we change the behavior. Those specs will need to be changed in order to have the service execute on a per-status basis, so those assertions will need to be changed manually and explicitly reviewed in the diffs of merge requests that alter the behavior.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by drew stachon

Merge request reports