Skip to content

Fix yaml viewer padding not changing color

Alexander Turinske requested to merge 332073-update-yaml-editor-styling into master

What does this MR do?

Fix yaml viewer padding not changing color

  • a user can update the color preferences of the text editor
  • the yaml viewer/editor was not updating colors appropriately because of some CSS hacking
  • with the newer version of monaco, we can remove the CSS hacks and properly fix the padding

Screenshots or Screencasts (strongly suggested)

Page Before After
Policy Drawer drawer_after
Policy Editor - Rule Mode No visual change
Policy Editor - YAML mode new new_top new_left

How to setup and validate locally (strongly suggested)

  1. Upload a GitLab Ultimate license
  2. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  3. Navigate to Security & Compliance => Threat Monitoring => Policies tab
  4. Click New policy
  5. Inspect the editor

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332073 (closed)

Edited by Alexander Turinske

Merge request reports