Skip to content

Mark feature flags in Gitlab/MarkUsedFeatureFlags only once

Peter Leitzen requested to merge pl-rubocop-speedup-mark-used-feature-flags into master

What does this MR do?

Mark dynamic feature flags and feature flags for usage data counters only once per whole rubocop run instead of once per file.

This reduces the overall runtime of this cop drastically:

time bundle exec rubocop -C false -f q --only Gitlab/MarkUsedFeatureFlags
  • Before: ~8m53.589s
  • After: ~3m56.036s

For cached runs (rubocop --cache true - the default) Gitlab/MarkUsedFeatureFlags does not track feature flags at all because this cop is skipped. tmp/feature_flags remains empty. On CI, however, we are disabling caching for this specific cop.

Screenshots or Screencasts (strongly suggested)

n/a

How to setup and validate locally (strongly suggested)

Run:

time bundle exec rubocop -C false --only Gitlab/MarkUsedFeatureFlags

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports