Skip to content

Clarify use of resolvers in code

charlie ablett requested to merge cablett-clarify-resolver-reuse into master

What does this MR do?

I realised the documentation wasn't 100% clear that you could re-use resolver classes (that is, declare that the same resolver class could be used to resolve two different fields). What we want to avoid is instantiation and re-use of the same resolver object, which we need to leave up to the framework to manage.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports