Skip to content
Snippets Groups Projects

Require password confirmation when user changes their primary email

What does this MR do?

With this MR, user is prompted with a modal to re-authenticate with their current password, when they want to save changes to their primary email.

This MR solves for #339145 (closed).

When user changes their primary email, a re-authentication with current user password is required, unless the user is signed in via OmniAuth/LDAP/SAML/etc. and they do not have a local password.

Implementation detail: frontend doesn't prompt for the password when password_automatically_set? returns true.

Note: It can be extended to require password confirmation for changes to some other user attributes (by adding to ATTRS_REQUIRING_PASSWORD_CHECK).

Screenshots or Screencasts (strongly suggested)

Screen_Recording_2021-09-20_at_6.26.29_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Magdalena Frankiewicz

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ezekiel Kigbo
  • Ezekiel Kigbo requested review from @blabuschagne

    requested review from @blabuschagne

  • Brandon Labuschagne removed review request for @blabuschagne

    removed review request for @blabuschagne

  • Magdalena Frankiewicz marked this merge request as ready

    marked this merge request as ready

  • Magdalena Frankiewicz changed the description

    changed the description

  • changed milestone to %14.4

  • Ezekiel Kigbo added 1 commit

    added 1 commit

    • 1db690d8 - Address minor review comments

    Compare with previous version

  • Ezekiel Kigbo requested review from @blabuschagne

    requested review from @blabuschagne

  • Brandon Labuschagne approved this merge request

    approved this merge request

  • Brandon Labuschagne removed review request for @blabuschagne

    removed review request for @blabuschagne

  • Drew Blessing removed review request for @dblessing

    removed review request for @dblessing

  • added 1 commit

    • 79762265 - Do not prompt for password if it is automatically set

    Compare with previous version

  • Magdalena Frankiewicz marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

    marked the checklist item I have self-reviewed this MR per code review guidelines. as completed

  • Magdalena Frankiewicz marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

    marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed

  • Magdalena Frankiewicz marked the checklist item I have followed the style guides. as completed

    marked the checklist item I have followed the style guides. as completed

  • Magdalena Frankiewicz marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed

    marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading