Require password confirmation when user changes their primary email
What does this MR do?
With this MR, user is prompted with a modal to re-authenticate with their current password, when they want to save changes to their primary email.
This MR solves for #339145 (closed).
When user changes their primary email, a re-authentication with current user password is required, unless the user is signed in via OmniAuth/LDAP/SAML/etc. and they do not have a local password.
Implementation detail: frontend doesn't prompt for the password when password_automatically_set?
returns true
.
Note: It can be extended to require password confirmation for changes to some other user attributes (by adding to ATTRS_REQUIRING_PASSWORD_CHECK
).
Screenshots or Screencasts (strongly suggested)
Screen_Recording_2021-09-20_at_6.26.29_PM
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team