Skip to content

Update security policy editor rule button styling

Alexander Turinske requested to merge 332072-update-editor-rule-button into master

What does this MR do?

Update security policy editor rule button styling Alexander Turinske authored 5 minutes ago

  • update styling to match add alert button
  • refactor components to pull out i18n strings from the template
    • we are moving from NetworkPolicies to SecurityOrchestration for strings that will be used for more than just the network policy type
  • update namespaces of some i18n strings

Screenshots or Screencasts (strongly suggested)

Before After
rule_before rule_after

How to setup and validate locally (strongly suggested)

  1. Upload a GitLab Ultimate license
  2. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  3. Navigate to Security & Compliance => Threat Monitoring => Policies tab
  4. Click New policy
  5. Inspect the editor

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332072 (closed)

Merge request reports