Skip to content

Allow idempotent jobs to use load balancing

Nikola Milojevic requested to merge 325291-allow-idempotent-jobs into master

What does this MR do?

We decided to split !66280 (comment 650854524).

When a job for an idempotent worker is enqueued while another unstarted job is already in the queue, GitLab will drop the second job.

If a worker is using LB capabilities, the job will be executed and take into account only the first write-ahead location.

The deduplication should always take into account the latest write-ahead location into account, not the first one.

Proposed solution:

  • Replication strategy will store the latest WAL locations in Redis in case that the job is dropped due to the deduplication strategy.
  • We store this WAL location only if the job is configured to utilize LB capabilities (data_consistency != :always) and the write-ahead location has changed.
  • On job execution, the replication strategy will update job's hash with dedup_wal_locations containing the latest location from the Redis cache (in case it exists).
  • SidekiqServerMiddleware will use an updated dedup_wal_locations location when checking if the replica has caught up.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325291 (closed)

Merge request reports