Skip to content

Support multiple wal locations for each database

What does this MR do?

We decided to split !66280 (comment 650854524).

In order to add support for idempotent jobs for workers that are using load balancing capabilities, we first need to add support for multiple databases in our sidekiq load balancing middleware.

Support for multiple databases

For the Sidekiq that are using load balancing capabilities, we are currently storing write-ahead log location in job hash

job['database_write_location'] # contains primary write-ahead log location
job['database_replica_location'] # contains replica write-ahead log location in case we schedule a job from replica

In order to support multiple databases, we will update this format and add support for structure that will map correct wal location to corresponding database configuration name:

job['wal_locations'] = {
   main: 'A0/A12FB',
     ci: '0/B12EA'
}

For deduplication, each time when the job gets rejected, we will keep track of the latest wal_location per each database name.

Note: Until we add support for multiple databases to our load balancer, we will use the hardcoded key, only for the main database:

job['wal_locations'] = {
   main: 'A0/A12FB'
}

Since already scheduled jobs could still contain legacy database write location, instead of wal_locations, SidekiqServerMiddlware will support old keys

Screenshots or Screencasts (strongly suggested)

Screenshot_at_Sep_06_12-07-07

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325291 (closed)

Edited by Nikola Milojevic

Merge request reports