Skip to content

Change order of sidekiq LoadBalancing middleware

Nikola Milojevic requested to merge 325291-change-middleware-order into master

What does this MR do?

We decided to split !66280 (comment 650854524).

In order to add support for idempotent jobs for workers that are using load balancing capabilities, we need to change order how our sidekiq server and client middleware are loaded.

  • :Gitlab::Database::LoadBalancing::SidekiqClientMiddleware should be placed before ::Gitlab::SidekiqMiddleware::DuplicateJobs::Client middleware, so we can store WAL location in job hash before we deduplicate the job.
  • ::Gitlab::SidekiqMiddleware::DuplicateJobs::Server should be placed at the bottom, but before the ::Gitlab::Database::LoadBalancing::SidekiqServerMiddleware, this way, when we add support for deduplication, if job's wal location is updated by deduplication strategy, we can compare that updated location in SidekiqServerMiddleware.

Note: This MR just changes middleware order, and this is just a preparation work for #325291 (closed).

We can easily roll back if there are some negative consequences.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325291 (closed)

Merge request reports