Skip to content

Add policy name to ScanExecutionPolicyCommit mutation

Sashi Kumar Kumaresan requested to merge sk/339794-update-policy-name into master

What does this MR do?

Addresses #339794 (closed)

This MR adds a new argument name to ScanExecutionPolicyCommit mutation. Since we do not have a reference to a policy in the yaml file in policy project, the name of the policy is considered as an unique identifier. But if the name of the policy need to be updated, the old name has to mentioned explicitly to make it work.

Screenshots or Screencasts (strongly suggested)

Before After
Screen_Shot_2021-09-10_at_1.08.19_PM change_name

Update policy name: Screenshot_2021-09-01_at_3.12.08_PM

Different name while creating policy: Screenshot_2021-09-01_at_3.12.26_PM

Mutation
mutation createPolicy{
  scanExecutionPolicyCommit(input:{
    projectPath:"root/rails-demo",
    operationMode:REPLACE,
    name: Policy
    policyYaml: "name: Updated Policy\ntype: scan_execution_policy\ndescription: This policy enforces pipeline configuration to have a job with secret detection scan\nenabled: true\nrules:\n- type: pipeline\n  branches: \n    - master\nactions:\n- scan: secret_detection"
  }) {
    clientMutationId
    branch
    errors
  }
} 
Response
{
  "data": {
    "scanExecutionPolicyCommit": {
      "clientMutationId": null,
      "branch": "update-policy-1624288106",
      "errors": []
    }
  }
} 

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alexander Turinske

Merge request reports