Simplify issues counts query in issues page refactor (!69310) · Merge requests · GitLab.org / GitLab

Coung Ngo requested to merge 322755-simplify-issue-counts-query into master Aug 31, 2021

What does this MR do?

This MR makes some small improvements to the issues page Vue refactor (#322755 (closed)), behind feature flag vue_issues_list defaulted to off.

Simplify issues counts query
Remove filter token cloning as this now occurs within GlFilteredToken
Make the logic showing CSV buttons consistent
Await apollo mutation so it properly throws error

Screenshots or Screencasts (strongly suggested)

No visual changes

How to setup and validate locally (strongly suggested)

In rails console enable the feature flag
```
Feature.enable(:vue_issues_list)
```
Visit any project issues page such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/
Test out the functionality

Does this MR meet the acceptance criteria?

Conformity

I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
I have added/updated documentation, or it's not needed. (Is documentation required?)
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
I have self-reviewed this MR per code review guidelines.
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
I have followed the style guides.
This change is backwards compatible across updates, or this does not apply.

Availability and Testing

I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
I have tested this MR in all supported browsers, or it's not needed.
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

Label as security and @ mention @gitlab-com/gl-security/appsec
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team

Related to #322755 (closed)

Simplify issues counts query in issues page refactor