Skip to content

Allow dots in Helm channel

Mathieu Parent requested to merge sathieu/gitlab:dot-in-helm-channel into master

What does this MR do?

Rationale: Some projects may want to create channel based on on versions: v1.x, v2.x, ...

The way Rails route works don't allow dots in route path segment by default (see here). This MR allow any non slash character. The channel name should still match the Helm channel regexp (currently /\A[-\.\_a-zA-Z0-9]+\z/).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports