Clean up group_level_protected_environments feature flag
What does this MR do?
The feature has been fully rolled out on gitlab.com and no issues have been found so far. Therefore we clean up the feature flag to release the feature as GA.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %14.3
assigned to @shinya.maeda
- Resolved by Achilleas Pipinellis
requested review from @axil
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/group_protected_environments.md
doc/ci/environments/protected_environments.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs ( @alexbuijs
) (UTC+2, 5 hours behind@shinya.maeda
)Charlie Ablett ( @cablett
) (UTC+12, 5 hours ahead of@shinya.maeda
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Achilleas Pipinellis
added Technical Writing docsfeature labels
Allure report
allure-report-publisher
generated test report for f2c7030d!review-qa-smoke:
test reportmarked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
marked the checklist item I have added/updated documentation, or it's not needed. (Is documentation required?) as completed
marked the checklist item I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) as completed
marked the checklist item I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) as completed
marked the checklist item This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) as completed
marked the checklist item I have followed the style guides. as completed
marked the checklist item This change is backwards compatible across updates, or this does not apply. as completed
marked the checklist item I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) as completed
marked the checklist item I have tested this MR in all supported browsers, or it's not needed. as completed
marked the checklist item I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed. as completed
added 1 commit
- 41735677 - Clean up group_level_protected_environments feature flag
- Resolved by Dmytro Zaporozhets (DZ)
@bala.kumar Would you mind reviewing as backend reviewer? Thanks!
requested review from @bala.kumar
- Resolved by Achilleas Pipinellis
- Resolved by Achilleas Pipinellis
added 624 commits
-
41735677...9e0fc449 - 623 commits from branch
master
- d841ca03 - Clean up group_level_protected_environments feature flag
-
41735677...9e0fc449 - 623 commits from branch
added 1 commit
- 38ed6acf - Clean up group_level_protected_environments feature flag
removed review request for @axil
@axil
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in issue #339967 (closed)
mentioned in issue #339968 (closed)
requested review from @jaime and removed review request for @bala.kumar
requested review from @dzaporozhets and removed review request for @jaime
enabled an automatic merge when the pipeline for 39623583 succeeds
mentioned in commit 7dd67b23
added workflowstaging-canary label and removed workflowverification label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !69906 (merged)
mentioned in merge request !69908 (merged)
mentioned in merge request !69909 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!236 (merged)
mentioned in merge request !73210 (merged)