Skip to content

Refactor labels dropdown to GlDropdown

What does this MR do?

  • Uses GlDropdown in new labels widget.
  • Fixes margin jump when opening dropdown

The main changes impact dropdown_contents_labels_view.vue and dropdown_contents.vue. dropdown_button.vue gets deleted.

To test the changes locally, you will need a feature flag enabled:

The use of GlDropdownItem introduces some visual regression, mostly increasing spacing around label options. A refactor of label_item.vue will be done in a follow-up to fix it.

Feature.enable(:labels_widget)

After enabling FF, you can test issue sidebar labels.

Screenshots or Screencasts (strongly suggested)

Screenshot_from_2021-08-31_13-57-07

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332260 (closed)

Edited by Florie Guibert

Merge request reports