Fix merge request approvals accordion

What does this MR do?

The original intent of this MR was to take care of #336698 (closed) and change the Merge request approvals
checkboxes to use the GitLab UI form builder. While I was doing this I realized that the accordions didn't work correctly. The Merge request approvals
accordion was always open and wouldn't close. Also when you saved a setting in the Push rules
accordion it is closed after the reload of the page. So this MR fixes the issue with the accordions and changes the Merge request approvals
checkboxes to use the GitLab UI form builder

Screenshots

Before | After |
---|---|
Screen_Recording_2021-09-03_at_8.55.53_AM | Screen_Recording_2021-09-03_at_8.56.30_AM |

How to setup and validate locally

- Sign in as an admin (
root
on GDK) - Navigate to
/admin/push_rule

Does this MR meet the acceptance criteria?

Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- [-] I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
- I am not sure if the accordion functionality warrants a system/feature spec since they are quite expensive. The JavaScript responsible for the accordions is tested in spec/frontend/settings_panels_spec.js so we would really just be checking for the correct classes in a system/feature spec.
-
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Merge request reports
Activity
assigned to @peterhegman
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho
) (UTC+7, 14 hours ahead of@peterhegman
)Phil Hughes ( @iamphill
) (UTC+1, 8 hours ahead of@peterhegman
)test Quality for spec/features/*
Sanad Liaquat ( @sliaquat
) (UTC+5, 12 hours ahead of@peterhegman
)Maintainer review is optional for test Quality for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for 016ac9c0!review-qa-smoke:
test report
package-and-qa: test reportSetting label(s) ~"Category:Authentication and Authorization" devopsmanage sectiondev based on ~"group::access".
added devopsmanage sectiondev + 1 deleted label
@peterhegman, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
removed [deprecated] Accepting merge requests label
added 744 commits
-
a78e35ed...c8a5ead0 - 743 commits from branch
master
- 4fc9f8ad - Fix merge request approvals accordion
-
a78e35ed...c8a5ead0 - 743 commits from branch
marked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
- Resolved by Phil Hughes
@sstern can you review this MR when you have time?
requested review from @sstern
changed milestone to %14.3
added maintenancerefactor typebug labels
removed review request for @sstern
@sstern
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
@sstern
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
changed milestone to %14.4
added missed:14.3 label
added 3875 commits
-
4fc9f8ad...7202bb88 - 3874 commits from branch
master
- 9450779b - Fix merge request approvals accordion
-
4fc9f8ad...7202bb88 - 3874 commits from branch
added 106 commits
-
9450779b...e60ba66f - 105 commits from branch
master
- 016ac9c0 - Fix merge request approvals accordion
-
9450779b...e60ba66f - 105 commits from branch
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/382841692 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/382978622 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/382978622 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/382996376 downstream.The
gitlab-qa
downstream pipeline passed. .
requested review from @iamphill
enabled an automatic merge when the pipeline for 2527eb0f succeeds
mentioned in commit c5d581ea
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!306 (merged)
added releasedpublished label and removed releasedcandidate label
added typemaintenance label and removed tooling (archive) typebug labels