Skip to content
Snippets Groups Projects

Fix merge request approvals accordion

All threads resolved!

:book: What does this MR do?

The original intent of this MR was to take care of #336698 (closed) and change the Merge request approvals checkboxes to use the GitLab UI form builder. While I was doing this I realized that the accordions didn't work correctly. The Merge request approvals accordion was always open and wouldn't close. Also when you saved a setting in the Push rules accordion it is closed after the reload of the page. So this MR fixes the issue with the accordions and changes the Merge request approvals checkboxes to use the GitLab UI form builder

:camera: Screenshots

Before After
Screen_Recording_2021-09-03_at_8.55.53_AM Screen_Recording_2021-09-03_at_8.56.30_AM

:computer: How to setup and validate locally

  1. Sign in as an admin (root on GDK)
  2. Navigate to /admin/push_rule

:vertical_traffic_light: Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading