Add support for div, figure, figcaption in content editor
What does this MR do?
As per #338380 (closed), this MR adds support for rendering div
, figure
and figcaption
in content editor.
Related MRs:
-
Add support for div, figure, figcaption in content editor (
⬅ This MR) - Add support for collapsible content in content editor
- Add support for description lists in content editor
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
-
Create a new wiki page, or edit an existing one
-
Type in the following HTML in the markdown editor:
<div>plain text</div> <div> just a plain ol' div, not much to _expect_! </div> <figure> ![Elephant at sunset](elephant-sunset.jpg) <figcaption>An elephant at sunset</figcaption> </figure> <figure> ![A crocodile wearing crocs](croc-crocs.jpg) <figcaption> A crocodile wearing _crocs_! </figcaption> </figure>
-
Switch to new editor by clicking "use new editor".
-
The content renders successfully.
-
Save with or without making any changes.
-
Edit the page again.
-
Note that the markdown / HTML for the tags is correct.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #338380 (closed)
Edited by Himanshu Kapoor