Skip to content

Re-addition of the state column for members table

Etienne Baqué requested to merge 332592-readd-state-for-members into master

What does this MR do?

This MR adds a state column for the members table.

This was previously done in this MR, but this other MR removed this column because of an incident (more details in that MR description).

As detailed in this comment, we're now (re)adding this column as part of this MR.

Migration Up/Down

etienne@dell ~/src/gdk/gitlab(332592-readd-state-for-members ✗) rails db:migrate:up VERSION=20210830140524
== 20210830140524 AddStateToMember: migrating =================================
-- column_exists?(:members, :members)
   -> 0.0019s
-- add_column(:members, :state, :integer, {:limit=>2, :default=>0})
   -> 0.0271s
== 20210830140524 AddStateToMember: migrated (0.0375s) ========================

etienne@dell ~/src/gdk/gitlab(332592-readd-state-for-members ✗) rails db:migrate:down VERSION=20210830140524
== 20210830140524 AddStateToMember: reverting =================================
-- remove_column(:members, :state)
   -> 0.0008s
== 20210830140524 AddStateToMember: reverted (0.0075s) ========================

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332592 (closed)

Edited by Etienne Baqué

Merge request reports