Correct the scope of the GitHub personal access token
What does this MR do?
Correcting the scope of the personal access token created on GitHub for configuring a pull mirror.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added Support Team Contributions devopscreate docsfix groupsource code labels
requested review from @aqualls
assigned to @asmaa.hassan
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/project/repository/repository_mirroring.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %14.3
- Resolved by Asmaa Hassan
Everything here sounds sensible. Let me route it over to @igor.drozdov for a quick check. If he approves, I'll merge.
added Technical Writing tw-weight1 twdoing labels
requested review from @igor.drozdov
Setting label(s) Category:Source Code Management sectiondev based on groupsource code.
added Category:Source Code Management sectiondev labels
Hmm. I checked Igor's availability, and it's limited this week. I'll add in @vyaklushin. Hopefully this is an easy, quick review.
requested review from @vyaklushin
added 1 commit
- f5064f0d - Fixing the scope again to work for a private github repo
@asmaa.hassan Thanks for having a look! LGTM
@aqualls Back to you
removed review request for @igor.drozdov
@igor.drozdov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Amy Qualls
added tw-weight3 label and removed tw-weight1 label
- Resolved by Amy Qualls
mentioned in commit b597307d
- Resolved by Asmaa Hassan
Excellent. @asmaa.hassan, I've applied a couple of changes to your work - line wraps, and a couple of little fixes. Thanks for your patience while Igor looked at your contribution. I had no reason to believe the work was wrong, but I couldn't personally verify it myself.
All merged and done! Thanks, everyone.
mentioned in issue gitlab-com/support/support-team-meta#3734 (closed)
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue gitlab-com/support/support-team-meta#3744 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label