Skip to content

Fix disappearing badge in commit image thread edit

What does this MR do?

When the user is editing a comment of an image thread on the commit page, the badge disappears when the user saves the comment.

Before

Initial After Edit Refresh
image image image

2017-10-10_13.26.46

This MR

fix-disappearing-badge

Testing case

  1. Navigate to a commit page that contains an image.
  2. Make a comment on the image by clicking on the image and save that comment.
  3. Edit that previously said comment.
  • The badge on the avatar remains.

Note

If you tried to edit the comment again, the comment disappears completely. Note: this is an existing bug in production and there is an issue to address it 💪 > #339538 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #19804 (closed)

Edited by Samantha Ming

Merge request reports