Skip to content

Add dependency proxy image prefix to group type

Steve Abrams requested to merge 322839-dp-graphql-image-prefix into master

🔬 What does this MR do?

This MR adds the attribute dependency_proxy_image_prefix to the GroupType in GraphQL.

The value was previously calculated in a view helper, so I've moved that to the Group model so it can be accessed in both areas of the code.

📽 Screenshots or Screencasts (strongly suggested)

Screen_Shot_2021-08-26_at_12.28.03_PM

🎣 How to setup and validate locally (strongly suggested)

  1. Set up the dependency proxy with GDK

  2. Create a group

  3. Pull a few images through the group using the dependency proxy

  4. Query the data:

     query {
       group(fullPath: "<your-group-full-path>") {
         id,
         dependencyProxyImagePrefix
       }
     }

🐘 Database

This change does not introduce any new queries, it adds the option for one more calculated attribute to the existing query for the group.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #322839 (closed)

Edited by Steve Abrams

Merge request reports