Skip to content

Resolve "Update available K8s version on EKS creation with 1.20"

What does this MR do?

Adds Kubernetes 1.20 support for EKS cluster creation.

  • Update FE available versions
  • Update cloud formation template with allowed versions
  • Force template versions to be wrapped around quotes, otherwise Yaml.safe_load converts 1.20 to 1.2, then we get an AllowedValues error for the K8s version saying that 1.20 is not in the list of allowed values.

Manual QA

1.20 creation on GitLab

form

creating

gl_created

Cluster created on EKS

stack

eks_created

How to setup and validate locally (strongly suggested)

Follow these steps on GDK as you were using a self-managed GitLab instance:

https://docs.gitlab.com/ee/user/project/clusters/add_eks_clusters.html

On GDK one might get CSP header request failures to load some fields in the cluster form. To workaround this one could use a chrome extension to temporarily disable CSP check, or on firefox it's possible to disable it from about:config by toggling security.csp.enable.

**Important: if you do disable CSP, it's probably recommended to do it in a separate browser than the one you're browsing other sites. Also, remember to turn it back on!!! 🔒 **

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #337654 (closed)

Edited by João Alexandre Cunha

Merge request reports