Skip to content

Remove import path order linting

Mark Florian requested to merge remove-import-path-alphabetisation into master

What does this MR do?

This removes the import path order lint rule.

Previously, this would be disallowed by this rule:

import Vue, { nextTick } from 'vue';
import Mousetrap from 'mousetrap';

Because vue is alphabetically sorted after mousetrap. With this change, this order would be allowed.

Pros

  • Our imports would no longer need to be sorted alphabetically according to their import paths 🤷

Cons

  • Our imports would no longer need to be sorted alphabetically according to their import paths 🤷
  • We spent quite a lot of time sorting our imports according to this rule; this would waste that effort.

Vote!

Please vote on this MR:

  • 👍 if you're in favour of it (i.e., merge it)
  • 👎 if you oppose it (i.e., close it)
  • 🤷 if you don't mind either way
  • 💱 if none of the above (please also comment with your thoughts!)

Screenshots or Screencasts (strongly suggested)

n/a

How to setup and validate locally (strongly suggested)

n/a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Greiling

Merge request reports