Reset CI minutes notifications for new monthly tracking
What does this MR do?
Related to #290961 (closed)
The main goal of this MR is to reset new monthly data about CI minutes notifications sent to the customer. We already reset CI minutes consumption for the legacy tracking (done in namespace_statistics.shared_runners_seconds
). In this MR we are resetting the data for the new tracking that is done in ci_namespace_monthly_usages
where we track:
- the consumption, in
amount_used
- last notification sent out, in
notification_level
We reset this data:
- any time the CI minutes limits change for a given namespace:
- when CI monthly minutes change (
namespaces.shared_runners_minutes_limit
) due to the customer changing plan - when CI additional minutes change (
namespaces.extra_shared_runners_minutes_limit
) due to the customer purchasing more CI minutes
- when CI monthly minutes change (
- any time the CI minutes consumption is reset by admins
- I've also renamed
ClearNamespaceSharedRunnersMinutesService
toCi::Minutes::ResetUsageService
in order to be a service object underCi::Minutes::
namespace. This service is called when an admin resets the CI minutes consumption to0
.
- I've also renamed
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino