Move vulnerability statistics update out of transaction
What does this MR do?
Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/338085
When creating a vulnerability from Vulnerabilities::CreateService, Statistics::UpdateService and HistoricalStatistics::UpdateService in wrapped in the same transaction which creates the vulnerability. But since the transaction could fail only for ActiveRecord::RecordNotFound and it is independent of the vulnerability statistics update, it could be moved out of the transaction to reduce the time spent by the sub-transaction to create the vulnerability.
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team