Skip to content

Fix jobs_request_post_spec on sharding POC

Adrien Kohlbecker requested to merge ak/fix-spec into rails-6-1-ci-split2

What does this MR do?

Re-enables a commented spec.

The error was due to Ci::Group existing, and:

NoMethodError (undefined method `where' for Ci::Group:Class
Did you mean?  when):
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/app/services/ci/queue/build_queue_service.rb:30:in `builds_for_group_runner'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/app/services/ci/register_job_service.rb:112:in `each_build'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/app/services/ci/register_job_service.rb:54:in `process_queue'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/app/services/ci/register_job_service.rb:30:in `block in execute'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/lib/gitlab/ci/queue/metrics.rb:106:in `observe_queue_time'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/app/services/ci/register_job_service.rb:29:in `execute'
  /Users/ak/Work/Gitlab/gitlab-development-kit/gitlab/lib/api/ci/runner.rb:146:in `block (2 levels) in <class:Runner>'

See #336555 (closed)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adrien Kohlbecker

Merge request reports