Skip to content

Use the last Helm chart when downloading

Mathieu Parent requested to merge sathieu/gitlab:helm_get_last_chart into master

What does this MR do?

When uploading several Helm charts with the same name and version, two problems arise:

  • All (20 recent) charts are returned from the chart index endpoint, while only one for name/version should be
  • The older one is returned from the chart endpoint, while the most recent shoult

This MR fixes problem 2.

To fix problem 1, some complex SQL query is needed (I tried with DISTINCT ON without success).

Related issue: #337446 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mathieu Parent

Merge request reports